Document Fleet as a Go module workaround and remove Go module publishing workflow#48773
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis pull request removes the GitHub Actions workflow file Changes
Sequence Diagram(s)No sequence diagram generated, as this change is a deletion of a CI configuration file with no code execution flow to depict. Related Issues
Suggested Labels Suggested Reviewers Poem 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Removes the GitHub Actions workflow that attempted to “publish” Fleet’s Go module on every v4.* tag, and updates contributor docs to describe a workaround for using Fleet as a Go module.
Changes:
- Deleted
.github/workflows/publish-go-module.yml(tag-triggeredgo list -m ...@tagindexing trigger). - Updated contributor documentation around using Fleet as a Go module (content excluded from this review per policy).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish-go-module.yml | Removed the automated Go module “publish/index” workflow. |
| docs/Contributing/guides/README.md | Updated contributor docs (not reviewable here due to content exclusion policy). |
| docs/Contributing/guides/using-fleet-as-a-go-module.md | Documented Go module workaround details (not reviewable here due to content exclusion policy). |
Files excluded by content exclusion policy (2)
- docs/Contributing/guides/README.md
- docs/Contributing/guides/using-fleet-as-a-go-module.md
Comments suppressed due to low confidence (1)
.github/workflows/publish-go-module.yml:1
- This PR removes the publish-go-module workflow, but the linked issue (#42818) acceptance/test plan explicitly calls out making this workflow run on every v4.* tag so new versions appear in pkg.go.dev. If the intended direction has changed to a manual/documented workaround, please update the story/PR description accordingly and ensure there is still a reliable way to trigger Go proxy/pkg.go.dev indexing for new tags.
Also, consider removing publish-go-module.yml from .github/zizmor-gate.yml’s ignore list to avoid stale references.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves #42818.
Testing
Summary by CodeRabbit