Skip to content

Document Fleet as a Go module workaround and remove Go module publishing workflow#48773

Merged
lukeheath merged 2 commits into
mainfrom
42818-document-fleet-as-a-go-module-workaround
Jul 6, 2026
Merged

Document Fleet as a Go module workaround and remove Go module publishing workflow#48773
lukeheath merged 2 commits into
mainfrom
42818-document-fleet-as-a-go-module-workaround

Conversation

@lucasmrod

@lucasmrod lucasmrod commented Jul 6, 2026

Copy link
Copy Markdown
Member

Resolves #42818.

Testing

  • QA'd all new/changed functionality manually.

Summary by CodeRabbit

  • Chores
    • Removed the automated Go module publishing step from release workflows.
    • Go module releases are no longer pushed automatically during version tag publishes.

Copilot AI review requested due to automatic review settings July 6, 2026 15:24

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 94f852fd-37d4-4522-b512-b008dccbb8c2

📥 Commits

Reviewing files that changed from the base of the PR and between bb7f8cb and 321edf5.

⛔ Files ignored due to path filters (2)
  • docs/Contributing/guides/README.md is excluded by !**/*.md
  • docs/Contributing/guides/using-fleet-as-a-go-module.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • .github/workflows/publish-go-module.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/publish-go-module.yml

Walkthrough

This pull request removes the GitHub Actions workflow file .github/workflows/publish-go-module.yml, eliminating the release-triggered CI job that previously published the Go module github.com/fleetdm/fleet/v4 to proxy.golang.org on v4.* tag pushes. No source code or exported/public entity declarations were altered.

Changes

File Change Summary
.github/workflows/publish-go-module.yml Deleted the workflow, removing the automated Go module publish job.

Sequence Diagram(s)

No sequence diagram generated, as this change is a deletion of a CI configuration file with no code execution flow to depict.

Related Issues

Suggested Labels
ci, chore

Suggested Reviewers
None identified from provided context.

Poem
A workflow file once stood so tall,
Publishing modules for one and all.
Now it's gone, deleted clean,
No more releases to proxy seen.
A rabbit hops on, code refined. 🐇

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references the issue and manual QA, but it omits most required template sections and checklist details. Fill out the template sections, especially the summary, checklist items, testing details, and any relevant issue context.
Linked Issues check ⚠️ Warning The PR removes the Go module publishing workflow, which conflicts with issue #42818’s goal of publishing Fleet as a Go module. Restore or implement module publishing so releases publish to pkg.go.dev and can be consumed as a Go module.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR’s main changes: documenting a Go module workaround and removing the publishing workflow.
Out of Scope Changes check ✅ Passed The observed change set is focused on the Go module publishing workflow and related documentation, with no clear unrelated edits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 42818-document-fleet-as-a-go-module-workaround

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

Removes the GitHub Actions workflow that attempted to “publish” Fleet’s Go module on every v4.* tag, and updates contributor docs to describe a workaround for using Fleet as a Go module.

Changes:

  • Deleted .github/workflows/publish-go-module.yml (tag-triggered go list -m ...@tag indexing trigger).
  • Updated contributor documentation around using Fleet as a Go module (content excluded from this review per policy).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish-go-module.yml Removed the automated Go module “publish/index” workflow.
docs/Contributing/guides/README.md Updated contributor docs (not reviewable here due to content exclusion policy).
docs/Contributing/guides/using-fleet-as-a-go-module.md Documented Go module workaround details (not reviewable here due to content exclusion policy).
Files excluded by content exclusion policy (2)
  • docs/Contributing/guides/README.md
  • docs/Contributing/guides/using-fleet-as-a-go-module.md
Comments suppressed due to low confidence (1)

.github/workflows/publish-go-module.yml:1

  • This PR removes the publish-go-module workflow, but the linked issue (#42818) acceptance/test plan explicitly calls out making this workflow run on every v4.* tag so new versions appear in pkg.go.dev. If the intended direction has changed to a manual/documented workaround, please update the story/PR description accordingly and ensure there is still a reliable way to trigger Go proxy/pkg.go.dev indexing for new tags.

Also, consider removing publish-go-module.yml from .github/zizmor-gate.yml’s ignore list to avoid stale references.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lukeheath lukeheath merged commit fb88c9d into main Jul 6, 2026
13 checks passed
@lukeheath lukeheath deleted the 42818-document-fleet-as-a-go-module-workaround branch July 6, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish Fleet's Go module

4 participants