Cherry-pick #48794: Fix custom packages download button#48799
Merged
Conversation
**Related issue:** Resolves #48418 Fixes the missing download button for custom software packages on the software details page by gating the button on whether the package has a downloadable installer file, rather than on the package's source URL (which is empty for directly-uploaded custom packages). # Checklist for submitter ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually <img width="1400" height="1000" alt="FIXED-custom-package-receipts" src="https://github.com/user-attachments/assets/7be76a27-3f2f-463e-8cdd-481e6058be53" /> <img width="1400" height="1000" alt="FIXED-fma-010editor" src="https://github.com/user-attachments/assets/5ba0aaa9-c15c-4e4a-bd5a-342e100d164e" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Updated library item download visibility to rely on an explicit download permission, so the download button now appears only when downloading is allowed. * Aligned software page rows and stories with the new download behavior across active library items. * Refined related test coverage and examples to match the updated download-button logic. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.89.0 #48799 +/- ##
=========================================================
Coverage ? 67.48%
=========================================================
Files ? 3677
Lines ? 233561
Branches ? 12266
=========================================================
Hits ? 157621
Misses ? 61797
Partials ? 14143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
georgekarrv
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #48794 into the RC branch.