[FXC-5774] Remove binary artifacts and legacy release workflow#21
Merged
Conversation
Remove all binary libraries from lib/ (282 .so + 10 .a files). These are built from source by the build_and_release.yml workflow via stage.sh, making the committed binaries redundant. Delete create_release.yml which assumed binaries were pre-committed in the repo. The build_and_release.yml workflow replaces it entirely. Remove .gitattributes (LFS tracking for lib/) since lib/ no longer contains tracked binaries. Add .gitignore to prevent build artifacts and downloaded ESP sources from being accidentally re-committed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MIT moved ESP128 from PreBuilts/ to archive/ after releasing a newer version. Update download.sh to use the new URL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/(282.so+ 10.afiles). These are built from source bybuild_and_release.ymlviastage.sh, making committed binaries redundant.create_release.yml— it assumed binaries were pre-committed in the repo and is replaced bybuild_and_release.yml..gitattributes(LFS tracking forlib/) sincelib/no longer contains tracked binaries..gitignoreto prevent build artifacts (.so,.a) and downloaded ESP sources from being re-committed.Jira: https://flow360.atlassian.net/browse/FXC-5774
Test plan
build_and_release.ymlstill succeeds by triggering a manual workflow run