[FXC-7075] Upgrade ESP 1.28 → 1.29 with EGADS patches#22
Merged
Conversation
Update default version to 129 and probe PreBuilts/ before falling back to archive/, since MIT rotates older releases between the two locations. Version is now configurable via CLI argument. Keep ESP128-specific evaluate.c patch so older versions can still be built. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
egadsTopo129.patch: Wrap unprotected BRepAdaptor_Curve2d/D0/D1/D2 call sites in EG_getEdgeUVX, EG_getEdgeUVs, EG_getEdgeUVeval, EG_invEdgeUV, and EG_inFaceAlt with try/catch returning EGADS_GEOMERR. Prevents Standard_NullObject crashes on degenerate geometry. egadsIO129.patch: Enable INTERIM define and add NULL surface checks during STEP/IGES import — skip bodies with null face surfaces and return EGADS_NODATA if all bodies are invalid. Both patches verified to compile cleanly against ESP 129. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mikeparkflex
force-pushed
the
mike/FXC-7075-upgrade-esp-129
branch
from
594cab6 to
dfd5960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreBuilts/before falling back toarchive/for download URL (MIT rotates older releases between the two)bash download.sh 128)download.sh, gated by versionegadsTopo129.patch: Wrap unprotectedBRepAdaptor_Curve2d/D0/D1/D2calls inEG_getEdgeUVX,EG_getEdgeUVs,EG_getEdgeUVeval,EG_invEdgeUV, andEG_inFaceAltwith try/catch returningEGADS_GEOMERRegadsIO129.patch: EnableINTERIMdefine, add NULL surface checks during STEP/IGES import — skip bodies with null face surfacesJira: https://flow360.atlassian.net/browse/FXC-7075
Test plan
build_and_release.ymlworkflow on this branch and verify it builds successfullylibegads.socompiles without warningsbash download.sh 128🤖 Generated with Claude Code