[FXC-5449] allow varying refinements on axisymmetric body faces#1882
Merged
Conversation
…ying-refinement-faces
…ying-refinement-faces
…ying-refinement-faces
benflexcompute
requested changes
Mar 13, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ying-refinement-faces
…ying-refinement-faces
…ying-refinement-faces
…ying-refinement-faces
…ute/Flow360 into alexxu/varying-refinement-faces
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
benflexcompute
approved these changes
May 1, 2026
Contributor
Coverage report (flow360)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk due to the
flow360-schemadependency bump, which may change validation/serialization behavior at runtime. Code changes here are minimal (import/exports only).Overview
Adds support for the new schema volume entity
AxisymmetricSegmentby re-exporting it fromflow360/component/simulation/primitives.py.Bumps the
flow360-schemadependency from25.10.10b1to25.10.11b1(updatingpyproject.tomlandpoetry.lock) to pick up the underlying schema changes.Reviewed by Cursor Bugbot for commit 17371b1. Bugbot is set up for automated code reviews on this repo. Configure here.