Update and sync softmax interface to modern style - #1668
Open
elliottslaughter wants to merge 1 commit into
Open
Conversation
elliottslaughter
force-pushed
the
softmax
branch
from
August 28, 2026 17:10
4de4721 to
25687a6
Compare
elliottslaughter
marked this pull request as draft
August 28, 2026 17:13
elliottslaughter
force-pushed
the
softmax
branch
from
August 28, 2026 18:49
25687a6 to
22ace35
Compare
elliottslaughter
marked this pull request as ready for review
August 28, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1667, and NOT stacked on top of it. (I keep going back and forth, but the current version is independent.)
CPU kernel is still not implement. GPU kernel and test has been updated and should be in sync with task-spec now.
Properly implements
dimto match PyTorch semantics, which as far as I can tell wasn't working previously.This change is