Don't report a PipeWire restart that didn't happen - #8
Open
munzzyy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audio-driver-restart.shalways reports the PipeWire restart as having worked:The error goes to
/dev/null,|| trueswallows the exit status, and the success line runs unconditionally.That path can't really succeed as written. The script requires root at the top (
[[ $EUID -ne 0 ]] && exit 1), andsystemctl --useras root talks to root's own user manager, not the desktop user's session that owns the audio stack. So whoever runs this to fix a silent sound card is told PipeWire was restarted when nothing happened on the session that matters, and stops digging.This keeps the behaviour non-fatal but stops it claiming success, and says why so the operator knows where to look. I left the actual user-session targeting alone on purpose — resolving the right uid (
loginctl+runuser, orXDG_RUNTIME_DIR) is a design call, and I'd rather not guess at a convention for your test rigs. Happy to follow up with that if you want it.The rebind logic above it is untouched.