Skip to content

Android App start-up HUGE improvement#2194

Draft
uzzyDC wants to merge 2 commits intofloccusaddon:developfrom
uzzyDC:develop
Draft

Android App start-up HUGE improvement#2194
uzzyDC wants to merge 2 commits intofloccusaddon:developfrom
uzzyDC:develop

Conversation

@uzzyDC
Copy link
Contributor

@uzzyDC uzzyDC commented Mar 6, 2026

#2170 Removed hash calculation during android native app start up. Hash is not required prior loading tree view, but only prior remote sync to check for differences.
Start up time from 10-15 seconds to 0.1 seconds with 5k bookmarks and sd 8gen2.

… time from 10 seconds to 0.1 seconds with 5k bookmarks and sd 8gen2. Hash is not required prior loading tree view, but only prior remote sync to check for differences.
@uzzyDC uzzyDC marked this pull request as draft March 7, 2026 09:51
@uzzyDC
Copy link
Contributor Author

uzzyDC commented Mar 7, 2026

I think I introduced an issue with andoid app sync, I'm checking Native/Action.js to fix it.

@marcelklehr
Copy link
Member

I've tried to achieve the same thing with fewer changes, but didn't have time to test if this actually works: #2195

@uzzyDC
Copy link
Contributor Author

uzzyDC commented Mar 7, 2026

The fact is that NativeTree.load() Hash calc should be ignored only for app startup calls, when the tree view is loaded. The following calls behaviour should remain the same, reason why I introduced a skipHash parameter, which should have default value false (last commit on my branch).

NativeTree.load() is invoked in actions.js and NativeAccount.get().
I'm skipping hash only in NativeAccount.get(), which however I'm not 100% sure is called only at startup. Anyway, a deeper refactoring is probably required to handle properly this mod, need to get used to the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants