Skip to content

fix Calling get(0) without checking the event definitions of targetEvent - #4244

Closed
panshaobin wants to merge 1 commit into
flowable:mainfrom
panshaobin:main.7
Closed

fix Calling get(0) without checking the event definitions of targetEvent#4244
panshaobin wants to merge 1 commit into
flowable:mainfrom
panshaobin:main.7

Conversation

@panshaobin

Copy link
Copy Markdown
Contributor

fix Calling get(0) without checking the event definitions of targetEvent

@filiphr

filiphr commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@panshaobin if this can happen then please provide a test for this. We have

 if (sourceEvent.getEventDefinitions() != null && !sourceEvent.getEventDefinitions().isEmpty() && 
        (targetEvent.getEventDefinitions() == null || targetEvent.getEventDefinitions().isEmpty())) {

    return false;

}

in the beginning of the method. So if the source event definitions are null or empty and the target event definitions are null or empty then we are going to return earlier, which means at the place you added the target event definitions cannot be null or empty

@filiphr filiphr closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants