Skip to content

tests: runtime: Try to address test hang#12000

Open
cosmo0920 wants to merge 1 commit into
masterfrom
cosmo0920-address-unit-testing-hang
Open

tests: runtime: Try to address test hang#12000
cosmo0920 wants to merge 1 commit into
masterfrom
cosmo0920-address-unit-testing-hang

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Previously, out_forward runtime test hangs i\on some of the Linux environment.
This PR fixes this phenomenon.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Tests
    • Updated secure forward test settings to include worker and retry configuration for oversized pong handling.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f1546f2-8bf1-4ee1-9397-33b8f6e2baf2

📥 Commits

Reviewing files that changed from the base of the PR and between c2b1cfd and fd7788a.

📒 Files selected for processing (1)
  • tests/runtime/out_forward.c

📝 Walkthrough

Walkthrough

The secure-forward runtime test now configures the forward output with workers=1 and retry_limit=no_retries. No other test logic changed.

Changes

Forward runtime test setup

Layer / File(s) Summary
Forward output options
tests/runtime/out_forward.c
The flb_test_secure_forward_oversized_pong_reason setup adds workers set to 1 and retry_limit set to no_retries on the forward output.

Estimated review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • fluent/fluent-bit#11945: Modifies the same runtime forward test area and is closely related to the secure-forward test setup.

Suggested reviewers

  • edsiper

Poem

I hopped by the forward test,
With workers=1, it felt well-pressed.
No retries now on pongy trails,
Just tidy paths through runtime veils.
A carrot toast for tests that gleam,
🐰✨ in one small, sturdy scheme.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change intent: a runtime test update to address a hang in the forward test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-address-unit-testing-hang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant