Add comments to TestCheckMasterReady in pkg/ddc/efc/master_test.go#6024
Conversation
|
Hi @HpSuda. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds descriptive comments to the TestCheckMasterReady unit test in pkg/ddc/efc/master_test.go to explain the test setup, inputs, and validation steps. Feedback indicates that while the comments mention covering the 'not-ready' master state, the actual test cases omit the corresponding engine, meaning this state is never validated. It is recommended to add the missing test case or update the comments accordingly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
HpSuda
force-pushed
the
MasterReadyTestComment
branch
from
d85c58b to
b5e1d73
Compare
|
The new GoDoc comment on TestCheckMasterReady is accurate and improves readability. It follows the Go convention of starting with the function name and matches the behavior of EFCEngine.CheckMasterReady, which delegates to Helper.CheckAndSyncMasterStatus and updates EFCRuntime conditions. Looks good to me. Note: the DCO check is currently failing on this PR, so a sign-off (git commit --amend -s and force-push) will be needed before tide can merge. |
HpSuda
force-pushed
the
MasterReadyTestComment
branch
from
b5e1d73 to
5ea24ce
Compare
Signed-off-by: Suda <2284528633@qq.com>
HpSuda
force-pushed
the
MasterReadyTestComment
branch
from
5ea24ce to
f7f3364
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6024 +/- ##
==========================================
+ Coverage 63.56% 64.86% +1.30%
==========================================
Files 479 480 +1
Lines 33276 33514 +238
==========================================
+ Hits 21151 21738 +587
+ Misses 10445 10051 -394
- Partials 1680 1725 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
All CI checks passed and maintainer has approved. Auto-approving to satisfy branch protection.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
2 participants
Add comments to TestCheckMasterReady in pkg/ddc/efc/master_test.go
Fixes #6025