Skip to content

This PR is to add comments to TestAlluxioFileUtils_exec in pkg/ddc/alluxio/operations/base_test.go. #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
insider193 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

This PR is to add comments to TestAlluxioFileUtils_exec in pkg/ddc/alluxio/operations/base_test.go. #6027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ddc/alluxio/operations/base_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,10 @@ func TestAlluxioFIleUtils_ReportCapacity(t *testing.T) {
}
}

// TestAlluxioFileUtils_exec tests the private exec method of AlluxioFileUtils.

@cheyang cheyang Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording nit on the new doc comment: the test calls exec(..., false) only on the error path and exec(..., true) only on the success path, and there are no assertions tied to the verbose flag itself (e.g. on log output). Saying it "covers calls with both disabled and enabled verbose output" reads a bit stronger than what is actually verified. Something like "exercises the method with both verbose=false and verbose=true" would line up more precisely with the assertions and avoid suggesting the verbose behaviour is independently checked.

// It mocks the exec implementation to verify that an error is returned when
// command execution fails and that no error is returned when execution succeeds.
// The test also covers calls with both disabled and enabled verbose output.
func TestAlluxioFileUtils_exec(t *testing.T) {
ExecWithoutTimeoutCommon := func(a AlluxioFileUtils, command []string, verbose bool) (stdout string, stderr string, err error) {
return "Type: COUNTER, Value: 6,367,897", "", nil
Expand Down
Loading