Skip to content

This PR is to add comments to Allocate in fluid/pkg/ddc/base/portallocator/random_allocator.go. #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sssq-max wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −0
Open

This PR is to add comments to Allocate in fluid/pkg/ddc/base/portallocator/random_allocator.go. #6030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a23e7
Update random_allocator.go
sssq-max Jun 18, 2026
7a64455
Update comment for Allocate in random_allocator.go.
sssq-max Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/ddc/base/portallocator/random_allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ func newRandomAllocator(pr *net.PortRange, log logr.Logger) (*RandomAllocator, e
}, nil
}

// Allocate is a no-op for RandomAllocator.
// Individual port allocation checks are not currently required by this allocator.
func (r *RandomAllocator) Allocate(port int) error {
// not judge whether port can be allocated or not
return nil
Expand Down