Support vulkan pileline cache - #40
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a cache_path field to FlutterVulkanRendererConfig to support the Vulkan pipeline cache in Impeller. The feedback recommends using the SAFE_ACCESS macro when retrieving cache_path to ensure backwards compatibility with older embedders, and adding a null check before calling OpenDirectory to prevent potential crashes or undefined behavior when cache_path is null.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ation Promote MarkFrameEnd() from SurfaceContextVK to ContextVK so the embedder path can call it directly instead of manually replicating its logic (which also missed DebugTraceMemoryStatistics).
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
While searching for relevant information to review this PR, I found the FlutterProjectArgs.persistent_cache_path flag. If it serves the same purpose, can it be replaced?
2 participants
Add Impeller Vulkan's pipeline cache directory for embedder.
flutter-tizen/embedder#181