Reserve flutter - #1021
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the a2ui_agent package to a2ui_flutter, updating its name, description, repository URL, and imports across the codebase. Feedback highlights a mismatch between the updated repository URL and the actual directory name, a redundant dependency on json_schema_builder that can be removed, and a test file that should be renamed to match the new package name for consistency.
| name: a2ui_flutter | ||
| description: The A2UI Flutter SDK. | ||
| version: 0.0.1-wip002 | ||
| repository: https://github.com/flutter/genui/tree/main/packages/a2ui_flutter |
There was a problem hiding this comment.
The repository URL points to packages/a2ui_flutter, but the directory in this pull request is still named packages/a2ui_agent. This mismatch will result in a broken link on pub.dev. If the directory renaming is planned for a later step, please keep this in mind; otherwise, the URL should be updated to match the actual directory path.
| a2ui_core: ^0.1.0 | ||
| json_schema_builder: ^0.1.3 |
There was a problem hiding this comment.
The json_schema_builder dependency is added here but does not appear to be directly imported or used anywhere in this package. Since a2ui_core already depends on it, and this package only depends on a2ui_core, this direct dependency is redundant and can be removed.
a2ui_core: ^0.1.0| // found in the LICENSE file. | ||
|
|
||
| import 'package:a2ui_agent/a2ui_agent.dart'; | ||
| import 'package:a2ui_flutter/a2ui_flutter.dart'; |
There was a problem hiding this comment.
The test file is still named a2ui_agent_test.dart even though the package and its main library have been renamed to a2ui_flutter. Renaming this file to a2ui_flutter_test.dart would maintain consistency with the new package name.
1 participant
No description provided.