add an examples app that has a gallery of pre-designed surfaces and allows editing/previewing A2UI JSON#761
Open
andrewkolos wants to merge 8 commits intoflutter:mainfrom
Open
add an examples app that has a gallery of pre-designed surfaces and allows editing/previewing A2UI JSON#761andrewkolos wants to merge 8 commits intoflutter:mainfrom
examples app that has a gallery of pre-designed surfaces and allows editing/previewing A2UI JSON#761andrewkolos wants to merge 8 commits intoflutter:mainfrom
Conversation
8a3cd41 to
06dd464
Compare
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an excellent composer example app, which will be a valuable tool for developing and testing A2UI surfaces. The app is well-structured, featuring AI-powered UI generation, a gallery of examples, and a live JSON editor. The overall implementation is solid. My feedback includes a few minor suggestions for improvement related to error handling, logging, and code clarity to enhance robustness and maintainability. The included fix for data model notifications in the genui package is also a great improvement.
Note: Security Review did not run due to the size of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788. Fixes #714.
Adds a new
composerapp that provides the following:GEMINI_API_KEYis available in the local environment).The count of changed files is near 100, but most of these are project scaffolding. You can focus on the dart source of the composer app.
There are some open questions I left unanswered in the interest of limiting the scope of this PR--the
Files Changedcount is already bloated from adding a new app. The big one worth mentioning is: should this new app be merged withcatalog_gallery? The gallery of individual components could simply be another tab in the UI. The other thing thatcatalog_gallerydoes is act as a suite of integration tests for CI. We could probably do the same thing with this new app: de-dupe redundant samples and port integration tests fromcatalog_gallery. I'm happy to do this in a follow-up PR.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.