[ci] grants write permission to create branch in remote#11269
[ci] grants write permission to create branch in remote#11269chunhtai wants to merge 2 commits intoflutter:mainfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Giving the entire job full write permissions to the repo seems very risky. Can we refactor to have a specific step do nothing but create the branch, and give only that step write access? /cc @jtmcdole for potential Infra input on access scoping. |
|
There isn't a good way to set granular permission for each step unless we use Personal access token. The best we can do is to separate out different job and gave different permission for each job. However, each job will be different run instance, and won't share the environment setup. This means the source code checkout and repo tool setup will have to be called for each job. I separated out the branch creation and pull request creation to be separated job to have slightly better permission control. If we want anything better, we will need to set up PAT, probably using the @fluttergithubbot . |
The branch release workflow failed with
https://github.com/flutter/packages/actions/runs/23134404669/job/67194648551
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2