Clarify ListTile error reporting in colored widget#13222
Open
Albert221 wants to merge 3 commits intoflutter:mainfrom
Open
Clarify ListTile error reporting in colored widget#13222Albert221 wants to merge 3 commits intoflutter:mainfrom
Albert221 wants to merge 3 commits intoflutter:mainfrom
Conversation
Updated the title and description to clarify that ListTile reports an error in debug mode when wrapped in a colored widget instead of throwing an exception.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for a breaking change regarding ListTile to clarify that it reports an error in debug mode instead of throwing a general exception. The reviewer noted that the title change should also be reflected in the main breaking changes index file for consistency.
Contributor
|
@Albert221, please resolve the conflict(s). |
Collaborator
|
Visit the preview URL for this PR (updated for commit c24b294): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
My colleagues (and I) had a heart attack when they saw an exception would be (supposedly) thrown in such a case until they dug deeper into the article's contents.
Updated the title and description to clarify that ListTile reports an error in debug mode when wrapped in a colored widget instead of throwing an exception.
Issues fixed by this PR (if any):
None
PRs or commits this PR depends on (if any):
None
Presubmit checklist
of 80 characters or fewer.