Skip to content

Add support for RBAC names with underscores#34

Merged
matheuscscp merged 1 commit intofluxcd:mainfrom
vocarista:bug/kustomize-controller/491
May 3, 2026
Merged

Add support for RBAC names with underscores#34
matheuscscp merged 1 commit intofluxcd:mainfrom
vocarista:bug/kustomize-controller/491

Conversation

@vocarista
Copy link
Copy Markdown

Fixes fluxcd/kustomize-controller#491

This PR resolves issues with parsing Kubernetes resources that contain underscores in their names, specifically addressing bugs encountered in the Flux kustomize-controller (related to issue kubernetes-sigs#491).

Key Changes

  • Fix Resource Name Parsing: Removed the restrictive "too many fields" validation in ParseObjMetadata to allow resource names (like those often found in RBAC) to contain underscores.
  • Expanded Test Coverage: Added unit tests to verify that ObjMetadata correctly parses names with single and multiple underscores.

Signed-off-by: Kumar Piyush <kr.piyush888@gmail.com>
Copy link
Copy Markdown
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@matheuscscp matheuscscp merged commit 0aaa266 into fluxcd:main May 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kustomization reconciliation failed: too many fields within:

2 participants