fix: handle nil network name for bridge/direct interfaces#189
Open
ajmeese7 wants to merge 1 commit into
Open
Conversation
When a VM has a bridge or macvtap interface (e.g. from a Vagrant public_network with :dev), libvirt represents it without a source network attribute. fog-libvirt's addresses() passes nic.network (nil) to list_networks, which calls lookup_network_by_name(nil), raising: TypeError: no implicit conversion of nil into String Fix by returning nil early in get_network_by_filter when the name filter is nil, and compacting the result in list_networks so that Fog::Collection#load never receives a nil entry. Fixes vagrant-libvirt state checks crashing on VMs with bridge NICs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a VM has a bridge or macvtap interface (e.g. from a Vagrant
public_networkwith :dev), libvirt represents it without a source network attribute.fog-libvirt'saddresses()passesnic.network(nil) tolist_networks, which callslookup_network_by_name(nil), raising:Fix by returning nil early in
get_network_by_filterwhen the name filter is nil, and compacting the result inlist_networksso thatFog::Collection#loadnever receives a nil entry.Fixes
vagrant-libvirtstate checks crashing on VMs with bridge NICs.