You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strip the pre-release suffix before computing the C preprocessor macro name and value in update_salesforce_sdk_constants. For 14.0.0-rc.0, the old code produced __SALESFORCE_SDK_14_0_0-rc_0 (invalid C identifier — hyphen is not allowed in macro names) and 14000-rc00 (not a valid integer). The fix derives both from base_version=${version%%-*} so the macro is always a valid C identifier.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.04%. Comparing base (1c71899) to head (aabbbc5). ⚠️ Report is 4 commits behind head on dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip the pre-release suffix before computing the C preprocessor macro name and value in
update_salesforce_sdk_constants. For14.0.0-rc.0, the old code produced__SALESFORCE_SDK_14_0_0-rc_0(invalid C identifier — hyphen is not allowed in macro names) and14000-rc00(not a valid integer). The fix derives both frombase_version=${version%%-*}so the macro is always a valid C identifier.GUS: W-23916129
Test plan
./setVersion.sh -v 14.0.0-rc.0completes without error; generated header contains valid#define __SALESFORCE_SDK_14_0_0 140000./setVersion.sh -v 14.0.0continues to work as before (no regression)