test(W-23836436): add non-DPoP pool server login test to ECALoginTests - #4140
Merged
Conversation
…vancedAuthentication passthrough Add test_givenNoDPoP_whenLoginViaPoolServer_thenSessionIsValid to ECALoginTests to verify plain ECA JWT login works through the pool server. Also removes an accidental ?? false default on forceAdvancedAuthentication in BaseAuthFlowTester that would have suppressed the flag when nil was intentionally passed.
|
||||||||||||||
…ter README The test body is an unconditional XCTSkip pending a RestClient fix for the missing nonce-challenge retry on the post-restart code path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4140 +/- ##
==========================================
- Coverage 71.62% 71.30% -0.33%
==========================================
Files 254 254
Lines 22697 22687 -10
==========================================
- Hits 16256 16176 -80
- Misses 6441 6511 +70
🚀 New features to boost your workflow:
|
Conflict in AuthFlowTester/README.md: upstream added testLogin_DPoP_ECA_Without_DPoP_Fails and test_givenBearerSession_whenUpgradeToDPoP_thenDPoPBound rows; kept both plus our XCTSkip note on the AppRestart test.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_givenNoDPoP_whenLoginViaPoolServer_thenSessionIsValidtoECALoginTests— verifies that a plain ECA JWT login through the pool server produces a valid session (non-DPoP path)?? falsedefault onforceAdvancedAuthenticationinBaseAuthFlowTester.launchLoginAndValidatethat would suppress the flag whennilwas intentionally passedTest plan
test_givenNoDPoP_whenLoginViaPoolServer_thenSessionIsValidpasses againstlogin.test1.pc-rnd.salesforce.com