Re-enable DPoP pool server test; fix L1 user-agent marker expectation - #4143
Merged
Conversation
W-23864247 (pool login server rejecting valid dpop_jkt) is fixed server-side. Removes the XCTSkip, adds useLoginPoolHost param to assertRevokeAndRefreshWorks, and uses kLoginServerProduction (L1) instead of kLoginServerMyDomain (L4) when routing through the pool server. Updates the README test table accordingly.
|
||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4143 +/- ##
==========================================
- Coverage 71.77% 71.59% -0.18%
==========================================
Files 254 254
Lines 22804 22804
==========================================
- Hits 16367 16327 -40
- Misses 6437 6477 +40
🚀 New features to boost your workflow:
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dpop_jkttoken exchanges withinvalid_dpop_proof; the server fix is confirmed and the test is now re-enabled.login.salesforce.com), so the user-agent carries the L1 (production) marker, not L4 (My Domain). Added auseLoginPoolHost: Bool = falseparameter to the publicassertRevokeAndRefreshWorksoverload that selectskLoginServerProductioninstead ofkLoginServerMyDomainwhentrue.test_givenDPoP_whenLoginViaPoolServer_thenTokenTypeIsDPoPno longer notes a skip; updated to describe the expected behavior.Changes
DPoPLoginTests.swift— removedXCTSkipblock; passeduseLoginPoolHost: truetoassertRevokeAndRefreshWorksBaseAuthFlowTester.swift— addeduseLoginPoolHostparameter; useskLoginServerProduction(L1) whentrueREADME.md— updated test-table rowTest plan
test_givenDPoP_whenLoginViaPoolServer_thenTokenTypeIsDPoPverified passing at 126.6s on iPhone 17 iOS 26.1 simulatorassertRevokeAndRefreshWorkscallers passuseLoginPoolHostasfalseby default, so L4 behavior is unchanged)