This repository was archived by the owner on Sep 19, 2022. It is now read-only.
Partial migration to support Slim 3 (and full phpunit 9 migration)#46
Open
Patabugen wants to merge 32 commits intofortrabbit:masterfrom
Open
Partial migration to support Slim 3 (and full phpunit 9 migration)#46Patabugen wants to merge 32 commits intofortrabbit:masterfrom
Patabugen wants to merge 32 commits intofortrabbit:masterfrom
Conversation
added 30 commits
January 26, 2022 15:16
|
Is slim still a thing? this package is fairly unmaintained. |
Author
|
SlimPHP itself is still going strong - though they're on Version 4 and my legacy project is using 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started migrating SlimControllers for a project of mine, before realising the project had too many other dependencies so I've stopped the attempt.
I thought I'd publish this in case it's useful to anyone else, or anyone would like to finish it off.
This is not backwards compatible - this version would not work with Slim2.
I've converted all the tests to run on phpunit 9 (largly thanks to the help of [rector/rector]) and have fixed about half of the tests.
I've not made any real progress on the Middleware or ServiceController tests.