fix: make update() return updated objects consistently#16
Merged
franccesco merged 3 commits intomainfrom Mar 20, 2026
Merged
Conversation
…ently headline.update() and goal.update() returned None while todo.update() and issue.update() returned the updated entity. Now all update() methods re-fetch and return the updated object after the PUT call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adapt goal and headline update tests to expect returned objects instead of None, and add GET mocks for the post-update details() re-fetch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a design inconsistency where
goal.update()andheadline.update()returnedNone, whiletodo.update()andissue.update()returned the updated entity. All fourupdate()methods now re-fetch and return the updated object after the PUT call.Changes
Operations
headline.update()now returnsHeadlineDetails(wasNone)goal.update()now returnsGoalInfo(wasNone)goal.details(goal_id)method (GET rocks/{goal_id}) to support the re-fetch pattern_transform_goal_details()mixin method for single-goal response transformationTests
Nonedetails()re-fetchTest plan
🤖 Generated with Claude Code