Merged
Conversation
Collaborator
|
LGTM, can you fix CI? Cheers! |
Collaborator
Sorry! CI was broken because of a different problem, which was addressed in #769 (which I just merged). Can you rebase? |
Collaborator
|
@Thorium now it's giving an error on SelfCheck target, rule AvoidSinglePipeOperator which is not enabled by default, but for SelfCheck we now try to enable all rules, can you have a look? It's just that this rule considers that if you don't use the pipe operator in a chained way, then there's no point to use it (so, more readable and less verbose to have |
knocte
reviewed
Nov 5, 2025
knocte
reviewed
Nov 5, 2025
knocte
force-pushed
the
async-parsing
branch
2 times, most recently
from
5066805 to
5fdb6e0
Compare
Suffix "Async" for methods is for methods that return "Task<Foo>", not "Async<Foo". For more info, see the PR for an upcoming FSharpLint rule: fsprojects#586
knocte
force-pushed
the
async-parsing
branch
from
aefc892 to
d0627fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose Async API for parsing.
This is useful when FSharpLint is used by other means than console app.