Add SynchronousFunctionNames rule #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
It would address that issue if it completely fixed it, but it doesn't. So you should change that word to "Contributes to..." |
Contributor
Author
Changed PR description. |
knocte
reviewed
Jan 29, 2026
knocte
reviewed
Jan 29, 2026
src/FSharpLint.Core/Rules/Conventions/SynchronousFunctionNames.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Jan 29, 2026
src/FSharpLint.Core/Rules/Conventions/Naming/SynchronousFunctionNames.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Jan 29, 2026
src/FSharpLint.Core/Rules/Conventions/SynchronousFunctionNames.fs
Outdated
Show resolved
Hide resolved
knocte
reviewed
Jan 29, 2026
knocte
reviewed
Jan 29, 2026
knocte
reviewed
Jan 29, 2026
knocte
reviewed
Jan 29, 2026
knocte
reviewed
Jan 29, 2026
webwarrior-ws
force-pushed
the
synchronous-function-names
branch
from
6c936c1 to
db38171
Compare
knocte
reviewed
Jan 29, 2026
webwarrior-ws
force-pushed
the
synchronous-function-names
branch
2 times, most recently
from
2f6ef00 to
f380e99
Compare
knocte
reviewed
Jan 29, 2026
| this.Parse """ | ||
| module Foo = | ||
| let Bar(): int = | ||
| let BazAsync(): int = |
Collaborator
There was a problem hiding this comment.
@webwarrior-ws I found a bug; to cover it let's rename this to asyncBaz, and then error msg should contain "baz" (not Baz)
Contributor
Author
There was a problem hiding this comment.
Added a test for it and fixed the rule.
Put error message into resources file Text.resx.
That use methods instead of functions.
For case when function is named asyncBar. Suggested name should also start from lowercase letter.
webwarrior-ws
force-pushed
the
synchronous-function-names
branch
from
d9939fc to
7eb3749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #517.