SynchronousFunctionNames,AsynchronousFunctionNames: ignore obsolete functions #837
+117
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Feb 2, 2026
tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/SynchronousFunctionNames.fs
Outdated
Show resolved
Hide resolved
Collaborator
|
@webwarrior-ws let's add one more refactoring commit that makes Async rule stop dependinig on Sync rule's code. And with this I'm not asking you to not respect DRY but to pull out the common code out of rule's types. |
For cases when function/method has `[<Obsolete>]` attribute.
To not fire on functions with `[<Obsolete>]` attribute.
For cases when function/method has `[<Obsolete>]` attribute.
To not fire on functions/methods with `[<Obsolete>]` attribute.
Moved common functions into NamingHelper.fs file instead of AsynchronousFunctionNames being dependent on SynchronousFunctionNames. Also use function isAttribute from NamingHelpers instead of reinventing the wheel.
webwarrior-ws
force-pushed
the
async-rules-obsolete
branch
from
3b9f730 to
1d69d96
Compare
Contributor
Author
Added refactoring commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore functions and methods marked with
[<Obsolete>]attribute.Contributes to #517.