[Repo Assist] fix: use toParam in form content helpers for correct date/time serialization (+4 tests, 296→300)

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

toFormUrlEncodedContent and toMultipartFormDataContent previously called x.ToString() / v.ToString() on field values, which gives locale-dependent output for DateTime/DateTimeOffset and incorrect output for DateOnly. They now delegate to toParam, which applies the same ISO 8601 formatting already used for query parameters.

Root cause

Both helpers were written before toParam existed as a dedicated serialization function. The TODO comment on the old code (// TODO: serialize? does not work with arrays probably) flagged the gap.

Changes

• RuntimeHelpers.fs:
  • toMultipartFormDataContent: replace x.ToString() with toParam x (skips null result — handles F# None options)
  • toFormUrlEncodedContent: replace Seq.map ... v.ToString() with Seq.choose ... toParam v (excludes entries where toParam returns null)
• RuntimeHelpersTests.fs: 4 new tests verifying ISO 8601 formatting of DateTime and DateTimeOffset values in both form content types

Test Status

✅ dotnet build — succeeded (0 errors)
✅ Unit tests — 300 passed, 0 failed (1 skipped pre-existing)
✅ dotnet fantomas --check — no formatting issues

Trade-offs

• toParam returns null for None options; the updated code skips those entries rather than serializing "". This is consistent with how getPropertyValues already filters out None values before calling these helpers.
• Arrays are still not expanded into multiple form entries; that remains a known limitation (the TODO comment has been removed since the fix is now partially addressed via toParam delegation).

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@96b9d4c39aa22359c0b38265927eadb31dcf4e2a

[Copilot]

Pull request overview

Updates form-content serialization to use the existing toParam helper so DateTime/DateTimeOffset/DateOnly values are formatted consistently (ISO 8601 / round-trip) instead of relying on locale-dependent ToString() output.

Changes:

• toMultipartFormDataContent: serialize non-stream values via toParam, skipping values where toParam returns null (e.g., None)
• toFormUrlEncodedContent: serialize values via toParam, excluding entries where toParam returns null
• Add 4 unit tests covering DateTime/DateTimeOffset formatting in both form content types

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/SwaggerProvider.Runtime/RuntimeHelpers.fs	Routes form body field serialization through toParam to ensure consistent ISO formatting and option handling.
tests/SwaggerProvider.Tests/RuntimeHelpersTests.fs	Adds regression tests for DateTime/DateTimeOffset formatting for both url-encoded and multipart form bodies.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sergey-tihon]

@copilot review inline comments and address what is applicable

[Copilot]

@copilot review inline comments and address what is applicable

Addressed the applicable inline review feedback in 77603d7 by tightening the new DateTime/DateTimeOffset tests to assert exact round-trip values (ToString("O")) after URL decoding for form-url-encoded content and exact body equality for multipart content. Targeted RuntimeHelpers test modules pass locally. No UI changes in this PR.

[sergey-tihon]

@copilot should data in form content be url encoded? it is expected behavior?

[Copilot]

@copilot should data in form content be url encoded? it is expected behavior?

Yes—application/x-www-form-urlencoded data is expected to be URL-encoded, and toFormUrlEncodedContent does that via FormUrlEncodedContent. For multipart/form-data, values are sent as multipart parts (not URL-encoded query-style), which is also expected behavior. No UI changes in this PR, so no screenshot is applicable.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• petstore.swagger.io
  • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.201/FSharp/fsc.dll @/tmp/MSBuildTempgHY5nu/tmp52e9d649019d473999a70181bd39f467.rsp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.