fix: Add migration to clean bloated ismp storages#1371
Open
fix: Add migration to clean bloated ismp storages#1371
Conversation
|
Crate versions that have been updated:
Runtime version has been increased. |
Contributor
|
@F3Joule did you test this on some mainnet fork such as lark? How many blocks does it need to complete? |
Contributor
|
consider using the more efficient |
Fix semantics
Contributor
|
what's the rationale behind placing this in the dispatcher pallet? |
Contributor
|
@F3Joule please include the outcome of the testing on lark in the PR description, after making sure that max(proof_size, ref_time) is no larger than 70% of the block limits |
Fix code formatting and benchmarks
|
Quick benchmark at commit b5bfa9c has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a multi-block migration aimed at cleaning up old entries in specific ISMP storages.
Related Issue
Fixes #1346
Tests to do