fix: replace deprecated SiCss3 with SiCss icon#1740
fix: replace deprecated SiCss3 with SiCss icon#1740w3bgr3p wants to merge 2 commits intogeneralaction:mainfrom
Conversation
Greptile SummaryThis PR replaces the deprecated Confidence Score: 5/5Safe to merge — minimal two-line build fix with no logic, behavior, or visual changes. The change swaps one deprecated icon name for its replacement across the import and a single usage site. The project already specifies No files require special attention.
|
| Filename | Overview |
|---|---|
| src/renderer/components/FileExplorer/FileIcons.tsx | Replaces deprecated SiCss3 import and usage with SiCss — a two-line fix that unblocks builds against react-icons v5. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[FileIcon component] --> B{isDirectory?}
B -- yes --> C[VscFolder / VscFolderOpened]
B -- no --> D{SPECIAL_FILES match?}
D -- yes --> G[Render icon]
D -- no --> E{EXTENSION_ICONS match?}
E -- yes --> G
E -- no --> F[VscFile fallback]
G --> H[IconErrorBoundary wraps render]
H --> I[Rendered icon]
style E fill:#d4edda
E -- css ext --> J["SiCss ✅ (was SiCss3)"]
J --> G
Reviews (1): Last reviewed commit: "fix: replace deprecated SiCss3 with SiCs..." | Re-trigger Greptile
|
Thanks, @w3bgr3p! LGTM, merging. |
|
@w3bgr3p could you please format, so that the format CI check passes? |
|
Then I'm happy to merge @w3bgr3p |
|
❯ npm run format:check
Checking formatting... |
|
Thanks! @w3bgr3p |
|
The format check is still failing @w3bgr3p |
|
Hi @w3bgr3p Heads-up: later this week we’ll be switching this repo from the current (“old”) Emdash codebase to the new v1 (beta launched last week; ~25% of our users have already moved over). Some PRs against the old code may become obsolete or need a quick rebase/adaptation after the switch. If you get a chance to try v1, We'd love your thoughts — reply here or share feedback on Discord: |
Summary
Replace deprecated
SiCss3icon withSiCssfrom react-icons/si.SiCss3was removed in a newer version of react-icons, causing a build failure.Fixes
N/A
Snapshot
N/A — no visual changes, build fix only
Type of change
Mandatory Tasks
Checklist