Skip to content

fix: replace deprecated SiCss3 with SiCss icon#1740

Closed
w3bgr3p wants to merge 2 commits intogeneralaction:mainfrom
w3bgr3p:main
Closed

fix: replace deprecated SiCss3 with SiCss icon#1740
w3bgr3p wants to merge 2 commits intogeneralaction:mainfrom
w3bgr3p:main

Conversation

@w3bgr3p
Copy link
Copy Markdown

@w3bgr3p w3bgr3p commented Apr 18, 2026

Summary

Replace deprecated SiCss3 icon with SiCss from react-icons/si.
SiCss3 was removed in a newer version of react-icons, causing a build failure.

Fixes

N/A

Snapshot

N/A — no visual changes, build fix only

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • I have self-reviewed the code

Checklist

  • I have read the contributing guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked if my PR needs changes to the documentation

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

This PR replaces the deprecated SiCss3 icon export (removed in react-icons v5) with SiCss in FileIcons.tsx, fixing a build failure. The change is limited to two lines — the import and its single usage in EXTENSION_ICONS — and has no functional or visual impact.

Confidence Score: 5/5

Safe to merge — minimal two-line build fix with no logic, behavior, or visual changes.

The change swaps one deprecated icon name for its replacement across the import and a single usage site. The project already specifies react-icons: "^5.5.0" in package.json, where SiCss3 was removed and SiCss is the correct replacement. No logic, API contracts, or UI behavior are affected. No P0 or P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
src/renderer/components/FileExplorer/FileIcons.tsx Replaces deprecated SiCss3 import and usage with SiCss — a two-line fix that unblocks builds against react-icons v5.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[FileIcon component] --> B{isDirectory?}
    B -- yes --> C[VscFolder / VscFolderOpened]
    B -- no --> D{SPECIAL_FILES match?}
    D -- yes --> G[Render icon]
    D -- no --> E{EXTENSION_ICONS match?}
    E -- yes --> G
    E -- no --> F[VscFile fallback]
    G --> H[IconErrorBoundary wraps render]
    H --> I[Rendered icon]

    style E fill:#d4edda
    E -- css ext --> J["SiCss ✅ (was SiCss3)"]
    J --> G
Loading

Reviews (1): Last reviewed commit: "fix: replace deprecated SiCss3 with SiCs..." | Re-trigger Greptile

@arnestrickmann
Copy link
Copy Markdown
Contributor

Thanks, @w3bgr3p!

LGTM, merging.

@arnestrickmann
Copy link
Copy Markdown
Contributor

@w3bgr3p could you please format, so that the format CI check passes?

@arnestrickmann
Copy link
Copy Markdown
Contributor

Then I'm happy to merge @w3bgr3p

@w3bgr3p
Copy link
Copy Markdown
Author

w3bgr3p commented Apr 20, 2026

❯ npm run format:check

emdash@0.4.49 format:check
prettier --check .

Checking formatting...
All matched files use Prettier code style!
checked

@arnestrickmann
Copy link
Copy Markdown
Contributor

Thanks! @w3bgr3p

@arnestrickmann
Copy link
Copy Markdown
Contributor

The format check is still failing @w3bgr3p

@arnestrickmann
Copy link
Copy Markdown
Contributor

Hi @w3bgr3p

Heads-up: later this week we’ll be switching this repo from the current (“old”) Emdash codebase to the new v1 (beta launched last week; ~25% of our users have already moved over). Some PRs against the old code may become obsolete or need a quick rebase/adaptation after the switch.

If you get a chance to try v1, We'd love your thoughts — reply here or share feedback on Discord:
https://discord.com/invite/f2fv7YxuR2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants