feat: Record log_byte client reports#8186
Merged
itaybre merged 9 commits intoJul 2, 2026
Merged
Conversation
Adds kSentryDataCategoryLogByte (= "log_byte") as a new data category alongside the existing kSentryDataCategoryLogItem. The byte category tracks how many bytes of log envelope data were discarded, matching the client-reports spec at https://develop.sentry.dev/sdk/telemetry/client-reports/ Changes: - SentryDataCategory.h: add kSentryDataCategoryLogByte = 15; shift kSentryDataCategoryUnknown to 16 - SentryDataCategoryMapper.h/m: add kSentryDataCategoryNameLogByte constant ("log_byte") and wire it through sentryDataCategoryForString, nameForSentryDataCategory - SentryHttpTransport.m: add recordLostLogBytes:reason: helper that records item.data.length bytes under kSentryDataCategoryLogByte; call it alongside the existing recordLostEvent / recordLostSpans calls in envelopeItemDropped:withCategory:, envelopeItemDeleted:withCategory:, and recordLostEventFor: - SentryDataCategoryMapperTests.swift: extend integer, string, and name-to-category round-trip tests to cover kSentryDataCategoryLogByte
tsushanth
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
June 25, 2026 01:36
NinjaLikesCheez
added
the
ready-to-merge
Member
|
Likewise here - thanks for your contribution! I've kicked off the CI, but would like another member of the team to verify this. I'd also suggest stacking it on #8185 so that the 'unknown' enum is correctly incremented across the changes. |
philprime
reviewed
Jun 25, 2026
philipphofmann
left a comment
philipphofmann
left a comment
Member
There was a problem hiding this comment.
Thanks a lot @tsushanth
tsushanth
force-pushed
the
fix-trace-metric-byte-data-category
branch
from
July 1, 2026 14:13
099c205 to
10a3c60
Compare
Contributor
Author
|
Added CHANGELOG entry under |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Add HTTP transport tests for log_byte recording on the rate-limit, cache-overflow, and send-error drop paths. Document why beforeSendLog only records log_item.
philipphofmann
changed the title
Record log_item and log_byte client outcomes when a log is dropped by beforeSendLog. The byte size is computed on a background queue so the calling thread isn't blocked.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc22393. Configure here.
Member
|
@tsushanth, thanks a lot for your help. I took the freedom and finished the PR. @itaybre, @philprime or @NinjaLikesCheez please give this PR another review, because I can't review my own code please. |
itaybre
reviewed
Jul 2, 2026
itaybre
enabled auto-merge (squash)
July 2, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Record the
log_byteclient outcome (the byte size of dropped logs) alongside the existinglog_itemcount, so we report the volume of discarded log data as required by the client reports spec.This covers logs dropped in the transport (rate limit, cache overflow, send errors) and by the
beforeSendLogcallback.💡 Motivation and Context
Fixes #8175.
💚 How did you test it?
Added unit tests for each drop path and for the byte-size calculation, including the encoding-failure fallback.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.