ci(flutter): skip integration tests on forks without auth token#3860
Draft
buenaflor wants to merge 2 commits into
Draft
ci(flutter): skip integration tests on forks without auth token#3860buenaflor wants to merge 2 commits into
buenaflor wants to merge 2 commits into
Conversation
Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Features
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
==========================================
+ Coverage 87.35% 91.50% +4.15%
==========================================
Files 338 105 -233
Lines 12283 3803 -8480
==========================================
- Hits 10730 3480 -7250
+ Misses 1553 323 -1230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0f0a415 | 1228.28 ms | 1233.51 ms | 5.23 ms |
| 5367726 | 1211.00 ms | 1216.73 ms | 5.73 ms |
| f80073a | 1249.75 ms | 1243.52 ms | -6.23 ms |
| d15266b | 1247.42 ms | 1251.29 ms | 3.87 ms |
| 2f63d89 | 1251.67 ms | 1263.94 ms | 12.27 ms |
| bfabaf2 | 1251.72 ms | 1253.38 ms | 1.67 ms |
| 8af916c | 1246.66 ms | 1240.79 ms | -5.87 ms |
| 9441966 | 1239.78 ms | 1254.00 ms | 14.22 ms |
| 54acf91 | 1257.65 ms | 1277.96 ms | 20.31 ms |
| 396cb30 | 1265.06 ms | 1265.73 ms | 0.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0f0a415 | 5.83 MiB | 6.28 MiB | 458.16 KiB |
| 5367726 | 5.73 MiB | 6.17 MiB | 455.87 KiB |
| f80073a | 5.73 MiB | 6.18 MiB | 464.26 KiB |
| d15266b | 5.83 MiB | 6.28 MiB | 462.36 KiB |
| 2f63d89 | 5.65 MiB | 6.09 MiB | 446.25 KiB |
| bfabaf2 | 5.53 MiB | 6.01 MiB | 487.95 KiB |
| 8af916c | 5.73 MiB | 6.18 MiB | 463.84 KiB |
| 9441966 | 5.83 MiB | 6.28 MiB | 459.62 KiB |
| 54acf91 | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 396cb30 | 5.53 MiB | 6.01 MiB | 488.17 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
flutter_test.yml, theSENTRY_AUTH_TOKEN_E2Esecret is unavailable on fork PRs (GitHub doesn't pass secrets to forks). Without a guard, thee2e/captureExceptiontest runs with an empty token, callssentry.io/api/...for verification, and always fails.All other integration tests use a
fakeDsnand don't need the token — they should still run on forks.Change
Added
skip: authToken.isEmptyto thecaptureExceptiontestWidgets call inside thegroup('e2e', ...)block inintegration_test.dart.authTokenis already aconst String.fromEnvironment('SENTRY_AUTH_TOKEN_E2E'), so this is a compile-time skip with no runtime overhead. Everything else in the integration test suite continues to run on forks as-is.