-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(devdocs): Clarify manually set data on scope and sendDefaultPii behavior #16299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarified that user-defined User objects on the scope are not stripped.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cleptric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to all data set, not just attributes. No manually set tag, context, data, etc. should be gated by sendDefaultPii.
Clarified the handling of sensitive data in SDK documentation, including details on PII flags and data filtering rules.
|
@cleptric put an alert above stating that all manual data should be sent regardless of the flag, does it look better? |
|
|
||
| <Alert level="info"> | ||
|
|
||
| When a user manually sets the data on the scope (user, contexts, tags, data, request, response, etc.), this data should not be gated by the _Send Default PII_ flag and should always be attached to all outgoing telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clarify that this also applies to data a user manually sets on a span, log, metric etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Clarified that user-defined User objects on the scope are not stripped.