Skip to content

Conversation

@romtsn
Copy link
Member

@romtsn romtsn commented Feb 9, 2026

Clarified that user-defined User objects on the scope are not stripped.

Clarified that user-defined User objects on the scope are not stripped.
@vercel
Copy link

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Feb 10, 2026 8:55am
sentry-docs Ready Ready Preview, Comment Feb 10, 2026 8:55am

Request Review

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to all data set, not just attributes. No manually set tag, context, data, etc. should be gated by sendDefaultPii.

Clarified the handling of sensitive data in SDK documentation, including details on PII flags and data filtering rules.
@romtsn romtsn changed the title chore(devdocs): Update data handling notes for user objects chore(devdocs): Clarify manually set data on scope and sendDefaultPii behavior Feb 9, 2026
@romtsn romtsn requested a review from cleptric February 9, 2026 11:52
@romtsn
Copy link
Member Author

romtsn commented Feb 9, 2026

@cleptric put an alert above stating that all manual data should be sent regardless of the flag, does it look better?


<Alert level="info">

When a user manually sets the data on the scope (user, contexts, tags, data, request, response, etc.), this data should not be gated by the _Send Default PII_ flag and should always be attached to all outgoing telemetry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify that this also applies to data a user manually sets on a span, log, metric etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit c81acb6 into master Feb 10, 2026
14 checks passed
@romtsn romtsn deleted the romtsn-patch-1 branch February 10, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants