Skip to content

Conversation

@supervacuus
Copy link
Collaborator

📜 Description

When merging tombstone and Native SDK events, we assume the message from the Native SDK. However, in most cases, this property will be empty from the Native SDK, whereas we explicitly construct a message from the tombstone that closely matches what debuggerd would print in logcat. This PR uses the tombstone message if the native envelope doesn't provide one.

💡 Motivation and Context

Better crash information.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@github-actions
Copy link
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (distribution) Add installGroupsOverride parameter by runningcode in #5066
  • (replay) Track custom masking usage via integration by markushi in #5070

Bug Fixes 🐛

  • (android) Merge tombstone and Native SDK event message. by supervacuus in #5095

Internal Changes 🔧

Deps

  • Bump getsentry/craft from 2.20.1 to 2.21.2 by dependabot in #5083
  • Bump github/codeql-action from 4.32.0 to 4.32.2 by dependabot in #5082
  • Update Native SDK to v0.12.6 by github-actions in #5071

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.02 ms 415.26 ms 48.24 ms
Size 1.58 MiB 2.28 MiB 718.66 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fcec2f2 328.91 ms 387.75 ms 58.84 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
23d6b12 354.10 ms 408.38 ms 54.28 ms
27d7cf8 314.17 ms 347.00 ms 32.83 ms
bbc35bb 298.53 ms 372.17 ms 73.64 ms
d15471f 342.08 ms 415.44 ms 73.35 ms
8687935 294.00 ms 304.02 ms 10.02 ms
d364ace 411.72 ms 430.81 ms 19.10 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms

App size

Revision Plain With Sentry Diff
fcec2f2 1.58 MiB 2.12 MiB 551.50 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
8687935 1.58 MiB 2.19 MiB 619.17 KiB
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants