feat(nitro): Instrument HTTP Server#19225
Draft
logaretm wants to merge 25 commits intoawad/create-nitro-sdk-metadatafrom
Draft
feat(nitro): Instrument HTTP Server#19225logaretm wants to merge 25 commits intoawad/create-nitro-sdk-metadatafrom
logaretm wants to merge 25 commits intoawad/create-nitro-sdk-metadatafrom
Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
Codecov Results 📊✅ 25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.58s All tests are passing successfully. Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
force-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
2 times, most recently
from
23a8b35 to
07ad5a1
Compare
logaretm
force-pushed
the
awad/create-nitro-sdk-metadata
branch
from
81b555e to
161862d
Compare
logaretm
force-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
from
6f1a78f to
c3fef9e
Compare
logaretm
force-pushed
the
awad/js-1128-nitro-use-tracing-channels-for-srvx-and-h3
branch
from
c3fef9e to
6799854
Compare
wadefletch
reviewed
Feb 10, 2026
| import { setServerTimingHeaders } from '../hooks/setServerTimingHeaders'; | ||
|
|
||
| export default definePlugin(nitroApp => { | ||
| // FIXME: Nitro hooks are not typed it seems |
There was a problem hiding this comment.
This has been fixed in nitrojs/nitro#4014
Member
Author
There was a problem hiding this comment.
Cool! thanks for fixing that and letting me know, I don't think it's released yet tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements HTTP server instrumentation for both
h3andsrvxby listening to their tracing channel events.h3TC PR: feat: experimental tracing support h3js/h3#1251srvxTC PR: feat: experimental tracing channel support h3js/srvx#141Closes #18123
This PR is part of a stack: