feat(deno): Export metrics API from Deno SDK#19305
Open
Conversation
3 tasks
1 task
272df60 to
723b598
Compare
Contributor
Codecov Results 📊Generated by Codecov Action |
723b598 to
a5ed28c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The metrics namespace is already exported from @sentry/core and re-exported by @sentry/node, but was missing from the Deno SDK. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a5ed28c to
fa576a4
Compare
chargome
reviewed
Feb 13, 2026
Member
There was a problem hiding this comment.
m: Please also export the according Metric type here
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deno tests run via Deno's native test runner, not vitest, so codecov cannot see their coverage. Adding packages/deno/** to the codecov ignore list prevents false coverage drops. Also gitignore deno.lock which is generated when running deno test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metricsto the@sentry/corere-export block inpackages/deno/src/index.tsmetricsnamespace is already exported from@sentry/coreand re-exported by@sentry/node, but was missing from the Deno SDKTest plan
yarn build:dev:filter @sentry/denopassescd packages/deno && yarn test— all 12 tests passeslint src/index.ts— no lint issues🤖 Generated with Claude Code
Closes #19307 (added automatically)