feat: add sentry_log() for plain-string log messages#1566
Merged
Conversation
Add a non-printf API that accepts a plain string body and explicit attributes. This avoids UB when user-provided text contains `%` characters, and prevents the SDK's parameter extraction from clobbering caller-provided `sentry.message.parameter.*` attributes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This was referenced Mar 7, 2026
Collaborator
|
Godot SDK PR with this branch and a test: |
limbonaut
approved these changes
Mar 8, 2026
mujacica
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sentry_log()— a non-printf API that accepts a plain string body and explicit attributes for downstream SDKs.The existing
sentry_log_*()functions treat the message as a printf format string. When callers like sentry-godot pass pre-formatted user text as the message, any%characters cause undefined behavior. On MSVC,%nkills the process immediately.Notice that using
"%s"together with a pre-formatted string as the first parameter is not a viable workaround (getsentry/sentry-godot#577) because it would clobber thesentry.message.parameter.0attribute.The new
sentry_log()overload skips printf interpretation and parameter extraction entirely, preserving the caller's attributes as-is.See also: