Skip to content

feat(argv): Support span streaming#6147

Merged
sentrivana merged 1 commit intomasterfrom
ivana/migrate-argv
Apr 28, 2026
Merged

feat(argv): Support span streaming#6147
sentrivana merged 1 commit intomasterfrom
ivana/migrate-argv

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented Apr 27, 2026

Description

The argv integration currently sets sys.argv on events, including transactions. In span streaming, this corresponds to setting an attribute on the segment span. The attr was added to Sentry conventions in getsentry/sentry-conventions@420bab8.

I also split up the span streaming transport format test into:

  1. a test that only checks the transport format (not so much the actual data, just that it's formatted correctly) and
  2. a test that checks that the default set of attributes we expect is set.

Issues

Closes #5998
Closes https://linear.app/getsentry/issue/PY-2300/migrate-argv-to-span-first

Reminders

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 27, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Codecov Results 📊


Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review April 27, 2026 10:57
@sentrivana sentrivana requested a review from a team as a code owner April 27, 2026 10:57
Comment thread tests/tracing/test_span_streaming.py
Comment thread tests/tracing/test_span_streaming.py
Comment thread sentry_sdk/traces.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 42058ea. Configure here.

Comment thread tests/tracing/test_span_streaming.py Outdated
@sentrivana sentrivana enabled auto-merge (squash) April 28, 2026 08:44
@sentrivana sentrivana merged commit 891bffc into master Apr 28, 2026
303 of 305 checks passed
@sentrivana sentrivana deleted the ivana/migrate-argv branch April 28, 2026 08:56
sentrivana added a commit that referenced this pull request Apr 29, 2026
This reverts commit 891bffc.

### Description
<!-- What changed and why? -->

#### Issues
<!--
* resolves: #1234
* resolves: LIN-1234
-->

#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate argv to span first

2 participants