fix(openai): Stop setting transaction status when child span fails#6192
Merged
alexander-alderman-webb merged 11 commits intomasterfrom May 5, 2026
Merged
fix(openai): Stop setting transaction status when child span fails#6192alexander-alderman-webb merged 11 commits intomasterfrom
alexander-alderman-webb merged 11 commits intomasterfrom
Conversation
Contributor
Codecov Results 📊✅ 146 passed | Total: 146 | Pass Rate: 100% | Execution Time: 21.68s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14148 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sentrivana
approved these changes
May 4, 2026
…ebb/openai/remove-get-current-span-responses
…b/openai/remove-set-span-errored
Base automatically changed from
webb/openai/remove-get-current-span-responses
to
master
May 5, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop modifying the transaction, since the transaction may not be managed by openai.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)