Skip to content

fix(typing): Add @sentry_sdk.traces.trace overloads to fix typing#6236

Merged
sentrivana merged 1 commit intomasterfrom
ivana/fix-trace-type
May 7, 2026
Merged

fix(typing): Add @sentry_sdk.traces.trace overloads to fix typing#6236
sentrivana merged 1 commit intomasterfrom
ivana/fix-trace-type

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented May 7, 2026

Changing sentry_sdk.trace to sentry_sdk.traces.trace introduced a whole avalanche of typing issues.

Adding the overloads we have for the original trace.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Codecov Results 📊

7 passed | Total: 7 | Pass Rate: 100% | Execution Time: 2.00s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 17471 uncovered lines.
❌ Project coverage is 20.26%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
traces.py 36.42% ⚠️ 199 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    25.10%    20.26%    -4.84%
==========================================
  Files          190       190         —
  Lines        21924     21911       -13
  Branches      7378      7378         —
==========================================
+ Hits          5502      4440     -1062
- Misses       16422     17471     +1049
- Partials       471       328      -143

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review May 7, 2026 13:07
@sentrivana sentrivana requested a review from a team as a code owner May 7, 2026 13:07
@sentrivana sentrivana enabled auto-merge (squash) May 7, 2026 13:13
@sentrivana sentrivana merged commit 3d59242 into master May 7, 2026
165 of 167 checks passed
@sentrivana sentrivana deleted the ivana/fix-trace-type branch May 7, 2026 13:16
cla7aye15I4nd pushed a commit to cla7aye15I4nd/sentry-python that referenced this pull request May 7, 2026
…etsentry#6236)

Changing `sentry_sdk.trace` to `sentry_sdk.traces.trace` introduced a
whole avalanche of [typing
issues](https://github.com/getsentry/seer/actions/runs/25495762136/job/74814929830?pr=6291).

Adding the overloads we have for the original `trace`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants