Skip to content

fix: resolve build issues on Unity 6.4 when targeting android #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 2 commits into from
May 22, 2026
Merged

fix: resolve build issues on Unity 6.4 when targeting android #2686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b37b9a
switched from implicit 'doLast' to explicit exec
bitsandfoxes May 18, 2026
5c72463
updated changelog
bitsandfoxes May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- The SDK now uses Gradle's built-in Exec task type when setting up the automated debug symbol upload. This resolves builds failing when targeting Android on Unity 6.4 ([#2686](https://github.com/getsentry/sentry-unity/pull/2686))
- When targeting iOS, the SDK no longer crashes in `urlSessionTask:setState:` when handling an `AVAssetDownloadTask` ([#2677](https://github.com/getsentry/sentry-unity/pull/2677))

### Features
Expand Down
85 changes: 41 additions & 44 deletions src/Sentry.Unity.Editor/Android/DebugSymbolUpload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,36 +46,41 @@ private string SymbolUploadTaskFormat
var stringBuilder = new StringBuilder();
stringBuilder.AppendLine("// Credentials and project settings information are stored in the sentry.properties file");
stringBuilder.AppendLine("afterEvaluate {");
stringBuilder.AppendLine("task sentryUploadSymbols {");
stringBuilder.AppendLine(" doLast {");
stringBuilder.AppendLine(" println 'Uploading symbols to Sentry.'");

var logsDir = $"{ConvertSlashes(_unityProjectPath)}/Logs";
Directory.CreateDirectory(logsDir);
stringBuilder.AppendLine($" def logFilePath = '{logsDir}/{SymbolUploadLogName}'");
stringBuilder.AppendLine(" def sentryLogFile = new FileOutputStream(logFilePath)");
stringBuilder.AppendLine(" def outputStream = new org.apache.tools.ant.util.TeeOutputStream(System.out, sentryLogFile)");
stringBuilder.AppendLine(" def errorStream = new org.apache.tools.ant.util.TeeOutputStream(System.err, sentryLogFile)");

stringBuilder.AppendLine(" exec {");
stringBuilder.AppendLine(" environment 'SENTRY_PROPERTIES', './sentry.properties'");
stringBuilder.AppendLine($" executable '{SentryCliMarker}'");
stringBuilder.AppendLine($" args = ['debug-files', 'upload'{UploadArgsMarker}]");
stringBuilder.AppendLine(" tasks.register('sentryUploadDebugFiles', Exec) {");
stringBuilder.AppendLine(" environment 'SENTRY_PROPERTIES', './sentry.properties'");
stringBuilder.AppendLine($" executable '{SentryCliMarker}'");
stringBuilder.AppendLine($" args = ['debug-files', 'upload'{UploadArgsMarker}]");
stringBuilder.AppendLine(" doFirst {");
stringBuilder.AppendLine(" println 'Uploading symbols to Sentry.'");
if (!_isExporting)
{
stringBuilder.AppendLine(" standardOutput outputStream");
stringBuilder.AppendLine(" errorOutput errorStream");
var logsDir = $"{ConvertSlashes(_unityProjectPath)}/Logs";
Directory.CreateDirectory(logsDir);
stringBuilder.AppendLine($" def sentryLogFile = new FileOutputStream('{logsDir}/{SymbolUploadLogName}')");
stringBuilder.AppendLine(" standardOutput = new org.apache.tools.ant.util.TeeOutputStream(System.out, sentryLogFile)");
stringBuilder.AppendLine(" errorOutput = new org.apache.tools.ant.util.TeeOutputStream(System.err, sentryLogFile)");
}
stringBuilder.AppendLine(" }");
stringBuilder.AppendLine(" }");

if (_isMinifyEnabled)
{
AppendProguardMappingTask(stringBuilder);
}

CheckMapping(stringBuilder);
stringBuilder.AppendLine(" tasks.register('sentryUploadSymbols') {");
stringBuilder.AppendLine(" dependsOn 'sentryUploadDebugFiles'");
if (_isMinifyEnabled)
{
stringBuilder.AppendLine(" dependsOn 'sentryUploadProguardMapping'");
}
stringBuilder.AppendLine(" }");
stringBuilder.AppendLine("}");
stringBuilder.AppendLine(string.Empty);
stringBuilder.AppendLine("tasks.assembleDebug.finalizedBy sentryUploadSymbols");
stringBuilder.AppendLine("tasks.assembleRelease.finalizedBy sentryUploadSymbols");
stringBuilder.AppendLine("tasks.bundleDebug.finalizedBy sentryUploadSymbols");
stringBuilder.AppendLine("tasks.bundleRelease.finalizedBy sentryUploadSymbols");

stringBuilder.AppendLine(" tasks.named('assembleDebug').configure { finalizedBy 'sentryUploadSymbols' }");
stringBuilder.AppendLine(" tasks.named('assembleRelease').configure { finalizedBy 'sentryUploadSymbols' }");
stringBuilder.AppendLine(" tasks.named('bundleDebug').configure { finalizedBy 'sentryUploadSymbols' }");
stringBuilder.AppendLine(" tasks.named('bundleRelease').configure { finalizedBy 'sentryUploadSymbols' }");

stringBuilder.AppendLine("}");
return stringBuilder.ToString();
Expand Down Expand Up @@ -164,7 +169,7 @@ public void AppendUploadToGradleFile(string sentryCliPath)
symbolUploadText = symbolUploadText.Replace(ProguardArgsMarker, uploadProguardArguments);

var gradleBuildFile = LoadGradleScript();
if (gradleBuildFile.Contains(SymbolUploadTaskStartComment) || gradleBuildFile.Contains("task sentryUploadSymbols"))
if (gradleBuildFile.Contains(SymbolUploadTaskStartComment) || gradleBuildFile.Contains("sentryUploadSymbols"))
{
throw new InvalidOperationException($"Failed to create Debug Symbol Upload Task. Task already exists in gradle file. A clean build should resolve this.{RaiseIssuePrompt}");
}
Expand Down Expand Up @@ -201,7 +206,7 @@ public void RemoveUploadFromGradleFile()
gradleBuildFile = regex.Replace(gradleBuildFile, "");

if (gradleBuildFile.Contains(SymbolUploadTaskStartComment) ||
gradleBuildFile.Contains("task sentryUploadSymbols") ||
gradleBuildFile.Contains("sentryUploadSymbols") ||
gradleBuildFile.Contains(SymbolUploadTaskEndComment))
{
throw new InvalidOperationException($"Failed to remove Debug Symbol Upload Task from gradle file. A clean build should resolve this.{RaiseIssuePrompt}");
Expand Down Expand Up @@ -264,32 +269,24 @@ internal List<string> GetSymbolUploadPaths(IApplication? application = null)
// Gradle doesn't support backslashes on path (Windows) so converting to forward slashes
internal static string ConvertSlashes(string path) => path.Replace(@"\", "/");

private void CheckMapping(StringBuilder stringBuilder)
private void AppendProguardMappingTask(StringBuilder stringBuilder)
{
if (!_isMinifyEnabled)
return;

stringBuilder.AppendLine(" println 'Uploading mapping file to Sentry.'");
stringBuilder.AppendLine(" tasks.register('sentryUploadProguardMapping', Exec) {");
stringBuilder.AppendLine(" environment 'SENTRY_PROPERTIES', './sentry.properties'");
stringBuilder.AppendLine($" executable '{SentryCliMarker}'");
stringBuilder.AppendLine($" args = ['upload-proguard'{ProguardArgsMarker}]");
stringBuilder.AppendLine(" doFirst {");
stringBuilder.AppendLine(" println 'Uploading mapping file to Sentry.'");
if (!_isExporting)
{
var logsDir = $"{ConvertSlashes(_unityProjectPath)}/Logs";
Directory.CreateDirectory(logsDir);
stringBuilder.AppendLine($" def mappingLogFilePath = '{logsDir}/{MappingUploadLogName}'");
stringBuilder.AppendLine($" def mappingLogFile = new FileOutputStream(mappingLogFilePath)");
stringBuilder.AppendLine(" def mappingOutputStream = new org.apache.tools.ant.util.TeeOutputStream(System.out, mappingLogFile)");
stringBuilder.AppendLine(" def mappingErrorStream = new org.apache.tools.ant.util.TeeOutputStream(System.err, mappingLogFile)");
}
stringBuilder.AppendLine(" exec {");
stringBuilder.AppendLine(" environment 'SENTRY_PROPERTIES', './sentry.properties'");
stringBuilder.AppendLine($" executable '{SentryCliMarker}'");
stringBuilder.AppendLine($" args = ['upload-proguard'{ProguardArgsMarker}]");
// stringBuilder.AppendLine($" args = ['debug-files', 'upload'{UploadArgsMarker}]");
if (!_isExporting)
{
stringBuilder.AppendLine(" standardOutput mappingOutputStream");
stringBuilder.AppendLine(" errorOutput mappingErrorStream");
stringBuilder.AppendLine($" def mappingLogFile = new FileOutputStream('{logsDir}/{MappingUploadLogName}')");
stringBuilder.AppendLine(" standardOutput = new org.apache.tools.ant.util.TeeOutputStream(System.out, mappingLogFile)");
stringBuilder.AppendLine(" errorOutput = new org.apache.tools.ant.util.TeeOutputStream(System.err, mappingLogFile)");
}
stringBuilder.AppendLine(" }");
stringBuilder.AppendLine(" }");
}

private string GetMappingFilePath(IApplication? application)
Expand Down
25 changes: 16 additions & 9 deletions test/Sentry.Unity.Editor.Tests/Android/DebugSymbolUploadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,20 @@ public void AppendUploadToGradleFile_AllRequirementsMet_AppendsUploadTask(bool i
"// Autogenerated Sentry symbol upload task [start]",
"// Autogenerated Sentry symbol upload task [end]",
"sentry.properties",
"tasks.register('sentryUploadDebugFiles', Exec)",
"args = ['debug-files', 'upload', '--il2cpp-mapping', '--include-sources'",
"tasks.assembleDebug.finalizedBy sentryUploadSymbols",
"tasks.assembleRelease.finalizedBy sentryUploadSymbols",
"tasks.bundleDebug.finalizedBy sentryUploadSymbols",
"tasks.bundleRelease.finalizedBy sentryUploadSymbols"
"tasks.register('sentryUploadSymbols')",
"dependsOn 'sentryUploadDebugFiles'",
"tasks.named('assembleDebug').configure { finalizedBy 'sentryUploadSymbols' }",
"tasks.named('assembleRelease').configure { finalizedBy 'sentryUploadSymbols' }",
"tasks.named('bundleDebug').configure { finalizedBy 'sentryUploadSymbols' }",
"tasks.named('bundleRelease').configure { finalizedBy 'sentryUploadSymbols' }"
};

if (!isExporting)
{
keywords.Add("standardOutput outputStream");
keywords.Add(DebugSymbolUpload.SymbolUploadLogName);
keywords.Add("standardOutput = new org.apache.tools.ant.util.TeeOutputStream(System.out, sentryLogFile)");
}

if (ignoreCliErrors)
Expand All @@ -175,10 +179,13 @@ public void AppendUploadToGradleFile_AllRequirementsMet_AppendsUploadTask(bool i

if (addMapping)
{
keywords.Add("tasks.register('sentryUploadProguardMapping', Exec)");
keywords.Add("args = ['upload-proguard'");
keywords.Add("dependsOn 'sentryUploadProguardMapping'");
if (!isExporting)
{
keywords.Add("standardOutput mappingOutputStream");
keywords.Add(DebugSymbolUpload.MappingUploadLogName);
keywords.Add("standardOutput = new org.apache.tools.ant.util.TeeOutputStream(System.out, mappingLogFile)");
}
}

Expand Down Expand Up @@ -233,17 +240,17 @@ public void RemoveUploadTaskFromGradleFile_MultipleConsecutiveRemovals_HandlesCo
for (var i = 0; i < 3; i++)
{
var gradleFile = File.ReadAllText(GetGradleFilePath());
StringAssert.DoesNotContain("task sentryUploadSymbols", gradleFile);
StringAssert.DoesNotContain("sentryUploadSymbols", gradleFile);

sut.AppendUploadToGradleFile(_fixture.SentryCliPath);

gradleFile = File.ReadAllText(GetGradleFilePath());
StringAssert.Contains("task sentryUploadSymbols", gradleFile);
StringAssert.Contains("sentryUploadSymbols", gradleFile);

sut.RemoveUploadFromGradleFile();

gradleFile = File.ReadAllText(GetGradleFilePath());
StringAssert.DoesNotContain("task sentryUploadSymbols", gradleFile);
StringAssert.DoesNotContain("sentryUploadSymbols", gradleFile);
}
}

Expand Down
Loading