feat(issue-progress): Default awaiting input page to progress sort#118069
Open
malwilley wants to merge 5 commits into
Open
feat(issue-progress): Default awaiting input page to progress sort#118069malwilley wants to merge 5 commits into
malwilley wants to merge 5 commits into
Conversation
Add an initialSort prop to IssueListOverview so individual pages can override the default sort order. The awaiting input page uses this to sort by progress instead of date.
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c718246. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff✅ no issues found |
The progress sort default causes 'Progress' to appear in both the column header and the sort dropdown. Use getAllByText to handle both.
The progress sort default causes 'Progress' to appear in both the column header and the sort dropdown. Scope the assertion to the actions bar using within() to target just the column header.
Add data-test-id="issue-list" to the ContainerPanel in IssueListTable and use it in the awaiting input test to scope the Progress column header assertion with within().
…input-progress-sort # Conflicts: # static/app/views/issueList/overview.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Awaiting Input" page now uses the new "Progress" sort