feat(seer-activity): Use a strategy for emailing issue owners#118106
Open
leeandher wants to merge 2 commits into
Open
feat(seer-activity): Use a strategy for emailing issue owners#118106leeandher wants to merge 2 commits into
leeandher wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 10cc314. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #118105 -- I had stacked it on top of a branch I closed and deleted, so GH won't let me set a new base destination branch, hence a new PR for the same branch
The existing email target works fine for users, (and would work for teams if they had an email), but not the ISSUE_OWNERS type, since that one wont have an email associated.
We dont derive the emails from the
determine_elligible_recipientsfunction (the way GroupEvent workflows do) since we don't have an `event.Instead, since activities always happen after a group exists, and presumably has been run through post_process, we just evaluate the
GroupAssigneeandGroupOwners. If aGroupAssigneeexists, they get emailed. If not, we email allGroupOwnersthat exist. These are all deduped, so no extra emails 🤞 \