fix(integrations): Store webhook request bodies without double encoding - #122361
Open
mrduncan wants to merge 1 commit into
Open
fix(integrations): Store webhook request bodies without double encoding#122361mrduncan wants to merge 1 commit into
mrduncan wants to merge 1 commit into
Conversation
Failure bodies in the Sentry App request buffer were passed through json.dumps even though they were already serialized strings, so the API returned double-encoded JSON that clients had to unwrap. Truncation also ran after encoding and sliced response.content as raw bytes, which cut a multi-byte sequence when a non-JSON body crossed the 1024 limit and raised UnicodeDecodeError when the entry was written to Redis. Bodies are now decoded first and truncated by character.
github-actions
Bot
added
the
Scope: Backend
mrduncan
marked this pull request as ready for review
August 20, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure bodies in the Sentry App request buffer were passed through json.dumps even though they were already serialized strings, so the API returned double-encoded JSON that clients had to unwrap.
Truncation also ran after encoding and sliced response.content as raw bytes, which cut a multi-byte sequence when a non-JSON body crossed the 1024 limit and raised UnicodeDecodeError when the entry was written to Redis. Bodies are now decoded first and truncated by character.
The badly encoded versions will age out 30 days after this is deployed.
See also: #121577