Skip to content

feat(monitors): improvements to app metric equation rendering - #122367

Open
bcoe wants to merge 5 commits into
masterfrom
equation-improvements-monitors
Open

feat(monitors): improvements to app metric equation rendering#122367
bcoe wants to merge 5 commits into
masterfrom
equation-improvements-monitors

Conversation

@bcoe

@bcoe bcoe commented Aug 20, 2026

Copy link
Copy Markdown
Member

Before

  • Leaks internal details about how an equation is formatted that a user never sees making the text we show confusing.
  • Doesn't fit on the screen and is clipped, making things more confusing.
Screenshot 2026-08-20 at 3 15 18 PM

After

Inspired by how the AI Query Agent renders its suggested filters:

Screenshot 2026-08-20 at 3 08 55 PM Screenshot 2026-08-20 at 3 08 51 PM Screenshot 2026-08-20 at 3 08 27 PM

Note

There are similar improvements we can make to non-equation metrics monitors, but figured I'd start here for now since users have complained specifically about this experience.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 20, 2026
@bcoe bcoe changed the title feat(monitors): improvement to app metric equation rendering feat(monitors): improvements to app metric equation rendering Aug 20, 2026
@bcoe
bcoe marked this pull request as ready for review August 21, 2026 13:52
@bcoe
bcoe requested review from a team as code owners August 21, 2026 13:52

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e184596. Configure here.

Comment thread static/app/views/detectors/components/details/metric/chart.tsx
@github-actions

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 94.35% 94.35% ±0%
Typed 134,148 134,177 🟢 +29
Untyped 8,040 8,042 🔴 +2
🔍 2 new type safety issues introduced

any-typed symbols (2 new)

File Line Detail
static/app/components/charts/components/tooltip.tsx 246 visibleSeriesParams (var)
static/app/components/charts/components/tooltip.tsx 309 serie (param)

This is informational only and does not block the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant