Skip to content

ref(ui): Remove unused optional arguments and fields - #122373

Draft
JonasBa wants to merge 4 commits into
getsentry:masterfrom
JonasBa:jonas/unused-optional-args-cleanup
Draft

ref(ui): Remove unused optional arguments and fields#122373
JonasBa wants to merge 4 commits into
getsentry:masterfrom
JonasBa:jonas/unused-optional-args-cleanup

Conversation

@JonasBa

@JonasBa JonasBa commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #122234. This diff comes from an experimental CLI. It looks at every place a component or function is used, checks which props and optional arguments are actually passed in, and flags the ones that never are. We deleted those unused props and arguments and left the old defaults in place so nothing should look or behave differently.

Summary

  • Remove unused optional arguments and object fields across static/app, static/gsApp, and static/gsAdmin (177 files, net -1084 lines).
  • Inline previous defaults so call sites keep the same runtime behavior.
  • Leave fields that are actually provided (JSON/API payloads, spreads, interface dispatch, tests).
  • Unexport replayMobilePlatforms and AssignedBy after they were no longer imported.
  • Restore Duration HTML attribute forwarding: Tooltip skipWrapper clones hover handlers onto the child, so dropping {...props} broke the duration tooltip.

Test plan

  • Spot-check a few high-traffic call sites that lost optional args (useMembers is not in this diff; detector/dashboard hooks dropped unused onSuccess/onError).
  • Confirm no caller still passes a removed argument (search for the old names at call sites if reviewing a specific file).
  • CI typecheck / frontend tests.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Made with Cursor

…vided.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 20, 2026
Jonas Badalic and others added 3 commits August 20, 2026 14:54
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ooltips.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant