ref(workflow_engine): Drop the coarse metric detector creation pre-check - #122382
Merged
Conversation
The POST handler short-circuited with a payment-options 400 when the org lacked the flag. Its own comment noted this was a coarse pre-check, and MetricIssueDetectorValidator.validate still calls _validate_metric_subscription_allowed for every data source, so disallowed datasets are still rejected with a dataset-specific 400.
github-actions
Bot
added
the
Scope: Backend
RudraPatel2003
marked this pull request as ready for review
August 24, 2026 17:22
cvxluo
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organizations:incidents flag is being made available to all plans. This PR is one of many to remove checks for this flag around the codebase.
Fixes ISWF-3270