ref(incidents): Remove organizations:incidents from dataset gating - #122384
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
RudraPatel2003
marked this pull request as ready for review
August 24, 2026 17:23
cvxluo
approved these changes
Aug 24, 2026
cvxluo
left a comment
cvxluo
left a comment
Contributor
There was a problem hiding this comment.
lgtm just make sure to merge after getsentry
RudraPatel2003
force-pushed
the
rudra-org-inc-backend-8
branch
from
August 24, 2026 18:29
e0467ad to
d9bc9c6
Compare
Contributor
Sentry Snapshot Testing
|
RudraPatel2003
force-pushed
the
rudra-org-inc-backend-8
branch
from
August 24, 2026 20:19
d9bc9c6 to
e090b89
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e090b89. Configure here.
Behavior changes in is_metric_subscription_allowed: - Dataset.Events metric alert subscriptions are no longer plan-gated at all; they fall through to the default allow. - Dataset.Transactions now requires only organizations:performance-view. - Dataset.EventsAnalyticsPlatform now requires only organizations:visibility-explore-view. Because Events becomes ungated, tests that used it to express "a metric detector the org isn't entitled to" are rewritten against Transactions/performance-view, and the two test_metric_detector_not_allowed_returns_404 cases are deleted as no longer expressible. Note for review: get_disallowed_metric_datasets still iterates Dataset.Events even though it can no longer be disallowed.
RudraPatel2003
force-pushed
the
rudra-org-inc-backend-8
branch
from
August 24, 2026 21:00
e090b89 to
237a0b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organizations:incidents flag is being made available to all plans. This PR is one of many to remove checks for this flag around the codebase.
This broke some getsentry tests, there is a PR for that: https://github.com/getsentry/getsentry/pull/21635
Fixes ISWF-3270