Allow SOPS to use custom AWS KMS and STS Endpoint#1679
Allow SOPS to use custom AWS KMS and STS Endpoint#1679anandavj wants to merge 1 commit intogetsops:mainfrom
Conversation
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I can't really comment on the AWS specific things, but as a general note, it looks like you should use gofmt to reformat the changes you made.
There was a problem hiding this comment.
This file is automatically generated, you should not manually modify it, but instead modify the protobuf definition and re-generate it. Right now protobuf regeneration doesn't work (see #1576) though, but I hope that will get fixed soon.
There was a problem hiding this comment.
thanks for the review, I've modify the protobuf definition and re-generate it
I use #1688 makefile but I won't include it on this PR as it's already covered in another PR
Thanks for the note, I've ran |
|
I apologize forgot to run the test after merging with main, I've fix the protobuf and finish test it in my local @felixfontein |
7bc71e5 to
70eba1e
Compare
|
You have quite a few commits in this PR that do not belong there. Could you please rebase your PR (instead of adding more merge commits) to get rid of the superfluous commits? Thanks. |
Signed-off-by: Ananda Vijaya <anandaprabu.trityavijaya@gmail.com>

There's case when I have custom endpoint for my AWS service, with this changes I could specify STS and KMS endpoint for my AWS service
Example usage: